Code Review
From Logic Wiki
What are Code Code Reviews
- A Code review is simply a systematic way of quantifying code quality
- Code reviews are important to continual improvement of your team and code
- By focusing on what is good and what needs improvement in your code, you can be successful
- Code reviews can improve your code if you avoid pitfalls such as politics, blame and 'not built here'
How to Review Code
- Taking your experience to bear ...
- Find things to laud and things to fix
- Look for common problems, nor for one-off issues
- Review 200-400 lines at a time
- Reviewing the whole code-base is time consuming
- No code is perfect code
- Maintainable code is a feature
How Not to Review Code
There are patterns to reviewing code - there are anti patterns too.
- Don't get emotional
- Don't focus on blame
- Don't redesign the code
- Don't judge based on how you would have coded it
- Don't include one-off problems
- Trying to find patterns to fix, not one-offs
